Repository navigation
[Uptime] Settings public API - #163400
Merged
Merged
[Uptime] Settings public API#163400
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
force-pushed
the
dynamic-settings
branch
from
August 9, 2023 08:00
af07fed to
7307b3b
Compare
shahzad31
force-pushed
the
dynamic-settings
branch
from
October 16, 2023 18:33
87a5920 to
363862c
Compare
shahzad31
marked this pull request as ready for review
October 17, 2023 06:40
fkanout
reviewed
Oct 17, 2023
fkanout
left a comment
Contributor
There was a problem hiding this comment.
AO changes LGTM with code review only.
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
fkanout
approved these changes
Oct 17, 2023
awahab07
reviewed
Oct 18, 2023
shahzad31
force-pushed
the
dynamic-settings
branch
from
October 18, 2023 16:45
2811233 to
9f067df
Compare
…into dynamic-settings
awahab07
approved these changes
Oct 23, 2023
awahab07
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Tested the UI as well as hitting the API endpoint publicly and it works as expected.
shahzad31
enabled auto-merge (squash)
October 23, 2023 12:02
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #162578
Settings public API !!
Also got an idea , in the effort involved for https://github.com/elastic/synthetics-dev/issues/247