Repository navigation
[SLO] Allow users to easily view good/bad events in Discover for event panel - #178008
Merged
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
simianhacker
force-pushed
the
slo-view-events-kql
branch
from
March 5, 2024 16:22
3f951eb to
e56fec4
Compare
kdelemme
reviewed
Mar 5, 2024
simianhacker
marked this pull request as ready for review
March 5, 2024 18:25
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
reviewed
Mar 5, 2024
kdelemme
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM, let me test locally
Member
Author
|
@elasticmachine merge upstream |
simianhacker
enabled auto-merge (squash)
March 6, 2024 23:00
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a link to Discover for the "Good vs Bad" event chart for non-APM indicators for the "Last 24 hours" with all the appropriate filters applied. If the indicator is a "Custom KQL", the link will include disabled filters for "Good events" and "Bad events". If the user clicks on a "Good" or "Bad" bar on the chart for the "Custom KQL" indicator, this will open Discover with the appropriate filter activated along with the appropriate time range for the bar.