Skip to content

[ES|QL] Fix wilcard complex scenarios - #178938

Merged
dej611 merged 4 commits into
elastic:mainfrom
dej611:fix/esql-wildcard-everywhere
Mar 21, 2024
Merged

dej611 merged 4 commits into
elastic:mainfrom
dej611:fix/esql-wildcard-everywhere

Conversation

@dej611

@dej611 dej611 commented Mar 19, 2024 •

Copy link
Copy Markdown
Contributor

Summary

Improves the wildcard validation logic to handle multiple occurrencies of wildcards.

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:ES|QL ES|QL related features in Kibana v8.14.0 labels Mar 19, 2024
@dej611

dej611 commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

/ci

@dej611

dej611 commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

/ci

@dej611
dej611 marked this pull request as ready for review March 19, 2024 15:04
@dej611
dej611 requested a review from a team as a code owner March 19, 2024 15:04
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611 dej611 added the v8.13.1 label Mar 19, 2024

@drewdaemon drewdaemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stratoula

stratoula commented Mar 20, 2024 •

Copy link
Copy Markdown
Contributor

This one?? 😄 Although the first asterisk is reduntant It work in es side and we should not mark it as invalid.

image

@dej611

dej611 commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

With dbb3d08 it should be fixed @stratoula . I've added also a test case to avoid regressions

@kibana-ci

Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / Reporting APIs Job parameter validation printablePdfV2 fails if width or height are non-numeric

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.9MB 2.9MB +209.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611
dej611 merged commit ad272c2 into elastic:main Mar 21, 2024
@kibanamachine

Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
❌ 8.13 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.13:
- [Security Solution] [Timeline] Clear pinned events correctly on note delete (#178537)

Manual backport

To create the backport manually run:

node scripts/backport --pr 178938

Questions ?

Please refer to the Backport tool documentation

@dej611

dej611 commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dej611 added a commit to dej611/kibana that referenced this pull request Mar 21, 2024
Improves the wildcard validation logic to handle multiple occurrencies
of wildcards.

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit ad272c2)
dej611 added a commit that referenced this pull request Mar 22, 2024
# Backport

This will backport the following commits from `main` to `8.13`:
- [[ES|QL] Fix wilcard complex scenarios
(#178938)](#178938)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-03-21T09:19:57Z","message":"[ES|QL]
Fix wilcard complex scenarios (#178938)\n\n## Summary\r\n\r\nImproves
the wildcard validation logic to handle multiple occurrencies\r\nof
wildcards.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ad272c2acf90598c12873d9cd731c793951f9dd2","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:ES|QL","v8.14.0","v8.13.1"],"number":178938,"url":"https://github.com/elastic/kibana/pull/178938","mergeCommit":{"message":"[ES|QL]
Fix wilcard complex scenarios (#178938)\n\n## Summary\r\n\r\nImproves
the wildcard validation logic to handle multiple occurrencies\r\nof
wildcards.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ad272c2acf90598c12873d9cd731c793951f9dd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178938","number":178938,"mergeCommit":{"message":"[ES|QL]
Fix wilcard complex scenarios (#178938)\n\n## Summary\r\n\r\nImproves
the wildcard validation logic to handle multiple occurrencies\r\nof
wildcards.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"ad272c2acf90598c12873d9cd731c793951f9dd2"}},{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@mistic

mistic commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

This PR didn't make it into the latest BC. Updating the labels.

@mistic mistic removed the v8.13.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.13.1 v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants