Skip to content

[UX/Maps] Fixing APM data view id - #179257

Merged
cauemarcondes merged 16 commits into
elastic:mainfrom
cauemarcondes:apm-fix-legacy-data-view-issue
Mar 28, 2024
Merged

[UX/Maps] Fixing APM data view id#179257
cauemarcondes merged 16 commits into
elastic:mainfrom
cauemarcondes:apm-fix-legacy-data-view-issue

Conversation

@cauemarcondes

@cauemarcondes cauemarcondes commented Mar 22, 2024 •
edited by kibanamachine
Loading

Copy link
Copy Markdown
Contributor

closes #177461

UX fix:
Screenshot 2024-03-22 at 14 03 58

Maps Obs layer
Screenshot 2024-03-22 at 16 11 31

@ghost

ghost commented Mar 22, 2024

Copy link
Copy Markdown

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes
cauemarcondes marked this pull request as ready for review March 22, 2024 16:51
@cauemarcondes
cauemarcondes requested a review from a team as a code owner March 22, 2024 16:51
@cauemarcondes
cauemarcondes requested a review from a team March 22, 2024 16:51
@cauemarcondes
cauemarcondes requested a review from a team as a code owner March 22, 2024 16:51
@cauemarcondes
cauemarcondes requested review from nreese and removed request for nreese March 22, 2024 16:51
nreese
nreese reviewed Mar 22, 2024
View reviewed changes
Comment thread ...gins/maps/public/classes/layers/wizards/solution_layers/security/create_layer_descriptors.ts Outdated
Comment thread ...gins/maps/public/classes/layers/wizards/solution_layers/security/create_layer_descriptors.ts Outdated
@botelastic botelastic Bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Mar 22, 2024
@elasticmachine

elasticmachine commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

jennypavlova
jennypavlova approved these changes Mar 25, 2024
View reviewed changes

@jennypavlova jennypavlova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

kpatticha
kpatticha reviewed Mar 25, 2024
View reviewed changes

@kpatticha kpatticha left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. it's buggy for the last 2 releases 😒 . I left some comments, let me know what you think

Comment thread x-pack/plugins/observability_solution/apm/public/components/app/settings/apm_indices/index.tsx
Comment thread x-pack/plugins/observability_solution/apm/server/routes/data_view/create_static_data_view.ts
Comment thread packages/kbn-apm-data-view/index.ts Outdated
Comment thread .../maps/public/classes/layers/wizards/solution_layers/observability/create_layer_descriptor.ts Outdated
jloleysens
jloleysens approved these changes Mar 26, 2024
View reviewed changes

@jloleysens jloleysens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM, did not test locally!

@cauemarcondes
cauemarcondes requested a review from kpatticha March 26, 2024 15:40
@cauemarcondes
cauemarcondes requested a review from nreese March 26, 2024 15:40
nreese
nreese approved these changes Mar 27, 2024
View reviewed changes

@nreese nreese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review only

@kibana-ci

kibana-ci commented Mar 28, 2024

Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 1158 1159 +1
ux 176 177 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/apm-data-view - 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +25.0B
maps 2.9MB 2.9MB +10.8KB
ux 165.2KB 165.6KB +346.0B
total +11.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 50.3KB 50.5KB +159.0B
ux 6.6KB 6.7KB +114.0B
total +273.0B
Unknown metric groups

API count

id before after diff
@kbn/apm-data-view - 4 +4

async chunk count

id before after diff
maps 29 28 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes
cauemarcondes merged commit aadfa5d into elastic:main Mar 28, 2024
@cauemarcondes
cauemarcondes deleted the apm-fix-legacy-data-view-issue branch March 28, 2024 12:14
@kibanamachine

kibanamachine commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
❌ 8.13 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 179257

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2024
@kibanamachine

kibanamachine commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179257 locally

This was referenced Apr 2, 2024
Closed
Merged
cauemarcondes added a commit that referenced this pull request Apr 4, 2024
@cauemarcondes @kibanamachine
[8.13][UX/Maps] Fixing APM data view id (#179816)
aa62595 
related to: #179257

Backport failed, so I'm manually applying the changes on 8.13

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine

kibanamachine commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179257 locally

3 similar comments
@kibanamachine

kibanamachine commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179257 locally

@kibanamachine

kibanamachine commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179257 locally

@kibanamachine

kibanamachine commented Apr 13, 2024

Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179257 locally

@cauemarcondes cauemarcondes added the backport:skip This PR does not require backporting label Apr 15, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 15, 2024
@cauemarcondes

cauemarcondes commented Apr 15, 2024

Copy link
Copy Markdown
Contributor Author

backport #179816

@neptunian neptunian mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes
@kpatticha kpatticha kpatticha approved these changes
@jloleysens jloleysens jloleysens approved these changes
@jennypavlova jennypavlova jennypavlova approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:fix Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.13.2 v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UX | Exp] Legacy APM data view usage

8 participants

@cauemarcondes @elasticmachine @kibana-ci @kibanamachine @nreese @kpatticha @jloleysens @jennypavlova