Skip to content

[Fleet] Enable subfeature privileges #179889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpollich merged 18 commits into from
Apr 12, 2024
Merged

[Fleet] Enable subfeature privileges #179889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c5618be
[Fleet] Enable subfeature privileges
nchaulet Apr 3, 2024
c85fc26
Fix security FTR tests
kpollich Apr 4, 2024
e7ded61
Fix security FTR tests (for real this time)
kpollich Apr 4, 2024
2a883db
Fix basic license test
kpollich Apr 5, 2024
4d84244
Merge branch 'main' into feature-enable-sufeature-privileges
kibanamachine Apr 5, 2024
a470c86
Merge branch 'main' into feature-enable-sufeature-privileges
juliaElastic Apr 8, 2024
c53bf4c
Merge branch 'main' into feature-enable-sufeature-privileges
juliaElastic Apr 8, 2024
0ec200b
Merge branch 'main' into feature-enable-sufeature-privileges
kpollich Apr 8, 2024
c1736fb
Fix tests again?
kpollich Apr 8, 2024
1713d72
Fix tests again???
kpollich Apr 8, 2024
ea7f159
Merge branch 'main' into feature-enable-sufeature-privileges
juliaElastic Apr 9, 2024
31c573f
Try setting privileges back to original value
kpollich Apr 9, 2024
f48adb8
Merge branch 'main' into feature-enable-sufeature-privileges
kibanamachine Apr 9, 2024
a1e4210
Merge branch 'main' into feature-enable-sufeature-privileges
juliaElastic Apr 10, 2024
b4d947d
Update privileges_basic.ts
kpollich Apr 10, 2024
dbcf408
Reenable subfeaturePrivileges flag + update kibana security tests
kpollich Apr 10, 2024
8af5f82
Fix basic tests
kpollich Apr 10, 2024
d358017
Merge branch 'main' into feature-enable-sufeature-privileges
kibanamachine Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/fleet/common/experimental_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const allowedExperimentalValues = Object.freeze<Record<string, boolean>>(
remoteESOutput: true,
agentless: false,
enableStrictKQLValidation: false,
subfeaturePrivileges: false,
subfeaturePrivileges: true,
enablePackagesStateMachine: true,
advancedPolicySettings: true,
});
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/fleet/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,8 @@ export class FleetPlugin
app: [PLUGIN_ID],
catalogue: ['fleet'],
privilegesTooltip: i18n.translate('xpack.fleet.serverPlugin.privilegesTooltip', {
defaultMessage: 'All Spaces is required for Fleet access.',
defaultMessage:
'All Spaces is required for Fleet access. Subfeatures privileges functionality is in technical preview and may be changed or removed completely in a future release.',
}),
reserved: {
description:
Expand Down
13 changes: 12 additions & 1 deletion x-pack/test/api_integration/apis/security/privileges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,18 @@ export default function ({ getService }: FtrProviderContext) {
],
observabilityAIAssistant: ['all', 'read', 'minimal_all', 'minimal_read'],
slo: ['all', 'read', 'minimal_all', 'minimal_read'],
fleetv2: ['all', 'read', 'minimal_all', 'minimal_read'],
fleetv2: [
'all',
'read',
'minimal_all',
'minimal_read',
'agents_all',
'agents_read',
'agent_policies_all',
'agent_policies_read',
'settings_all',
'settings_read',
],
fleet: ['all', 'read', 'minimal_all', 'minimal_read'],
actions: ['all', 'read', 'minimal_all', 'minimal_read'],
stackAlerts: ['all', 'read', 'minimal_all', 'minimal_read'],
Expand Down
14 changes: 13 additions & 1 deletion x-pack/test/api_integration/apis/security/privileges_basic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,19 @@ export default function ({ getService }: FtrProviderContext) {
],
observabilityAIAssistant: ['all', 'read', 'minimal_all', 'minimal_read'],
slo: ['all', 'read', 'minimal_all', 'minimal_read'],
fleetv2: ['all', 'read', 'minimal_all', 'minimal_read'],
// fleetv2: ['all', 'read', 'minimal_all', 'minimal_read'],
fleetv2: [
'all',
'read',
'minimal_all',
'minimal_read',
'agents_all',
'agents_read',
'agent_policies_all',
'agent_policies_read',
'settings_all',
'settings_read',
],
fleet: ['all', 'read', 'minimal_all', 'minimal_read'],
actions: ['all', 'read', 'minimal_all', 'minimal_read'],
stackAlerts: ['all', 'read', 'minimal_all', 'minimal_read'],
Expand Down