Repository navigation
[Log Explorer] Add logic to display highlights in Flyout - #170650
Merged
achyutjhunjhunwala merged 16 commits intoNov 10, 2023
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
tonyghiani
self-requested a review
November 6, 2023 16:10
achyutjhunjhunwala
marked this pull request as ready for review
November 7, 2023 14:16
Contributor
|
/oblt-deploy |
tonyghiani
requested changes
Nov 8, 2023
tonyghiani
left a comment
Contributor
There was a problem hiding this comment.
Well done overall, thanks for taking care of working on so many requirements 🙏
I left some notes on missing requirements or improvements we can bring in, let me know if you have any doubts, I'm happy to review them together!
Contributor
Author
|
@tonyghiani All review comments have been address and the PR is open for review again. Regarding the design with ellipsis, i had a discussion with @isaclfreire. In order to handle the Actions better, i am changing with the grid columns dynamically based on breakpoint. |
achyutjhunjhunwala
force-pushed
the
log-flyout-highlights
branch
from
November 9, 2023 13:53
d8676eb to
632c24c
Compare
tonyghiani
reviewed
Nov 10, 2023
tonyghiani
reviewed
Nov 10, 2023
tonyghiani
reviewed
Nov 10, 2023
tonyghiani
approved these changes
Nov 10, 2023
tonyghiani
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for this work 👍
achyutjhunjhunwala
enabled auto-merge (squash)
November 10, 2023 16:06
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #169504
What's pending