[Alert details page][Custom threshold] Add history chart for multiple conditions - #180578

🤖 GitHub comments

Nice work! For clarity, can we have multi condition with OR logic in a rule like this? And if so, if the first condition hasn't been met but the second one has, would the default view here look like "no alerts in the past 30 days" (bc it would show the first condition and how it hasn't been "violated" in that time period)?

Nice work! For clarity, can we have multi condition with OR logic in a rule like this? And if so, if the first condition hasn't been met but the second one has, would the default view here look like "no alerts in the past 30 days" (bc it would show the first condition and how it hasn't been "violated" in that time period)?

No, multi-conditions are used with AND logic.

No, multi-conditions are used with AND logic.

OK, thanks. For single condition rules, it might be nice to have the same drop-down with just the one single condition option, as a way for users to become familiar with that UI element, but I'll defer to @maciejforcone on that. Otherwise this looks like a great improvement for the rules.

OK, thanks. For single condition rules, it might be nice to have the same drop-down with just the one single condition option, as a way for users to become familiar with that UI element, but I'll defer to @maciejforcone on that. Otherwise this looks like a great improvement for the rules.

I added a condition to hide this selection for a single condition as I thought it might be confusing to see it when a user does not have any option to select from. I can remove that check in case having it regardless of the number of conditions is useful.

/ci

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Is it possible to show tooltip in dropdown menu items for long equations?

I noticed an issue with alert annotation label where it shows extra [1]. It may not be related to this PR.

Is it possible to show tooltip in dropdown menu items for long equations?

Added in 3360cb6

I noticed an issue with alert annotation label where it shows extra [1]. It may not be related to this PR.

I didn't change the logic about alert annotation, so I assume this would happen in one condition as well. Would you please create a ticket for it? Or if you let me know how to reproduce it, I can create an issue for it.

💚 Build Succeeded

• Buildkite Build
• Commit: 9bfab9e
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

History

• 💚 Build #203607 succeeded 4abcf33
• 💚 Build #203203 succeeded 3b7a2aa
• 💔 Build #203076 failed e48760c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

I didn't change the logic about alert annotation, so I assume this would happen in one condition as well. Would you please create a ticket for it? Or if you let me know how to reproduce it, I can create an issue for it.

created #180890