Repository navigation
[APM] Add section titles to span detail modal - #20717
Conversation
Needed titling for DB statement and Stacktrace on the page
|
Pinging @elastic/apm-ui |
| font-size: ${fontSize}; | ||
| color: ${colors.gray1}; | ||
| `; | ||
|
|
There was a problem hiding this comment.
Beautiful!
We already have a couple of headers. Maybe we could go over them at some point.
There was a problem hiding this comment.
@sqren Made sense to re-use those, although added a new smaller size to match the other style I created.
| export const HeaderXSmall = styled.h4` | ||
| margin: ${px(units.plus)} 0; | ||
| font-size: ${fontSize}; | ||
| ${props => props.css}; |
There was a problem hiding this comment.
if you wondered about the css prop, it's a neat/hacky trick for allowing real css: https://github.com/sqren/kibana/blob/3988e3639f7d354dc9b5578daf56b4d93fc00f53/x-pack/plugins/apm/public/components/app/TransactionDetails/Distribution/view.js#L68-L73
There was a problem hiding this comment.
Uhhh, that's very nice 👍
There was a problem hiding this comment.
yeah, it let's us have some standard headers, that can still be modified locally.
💔 Build Failed |
|
retest |
💔 Build Failed |
|
@sqren do you think I need to update the tests first? |
|
Ah, yes. Snapshots will need updating. From x-pack folder run this: |
💚 Build Succeeded |
* Adding fontSize from variables * SectionHeader style added * Adding section headers Needed titling for DB statement and Stacktrace on the page * Pluralization * Adding fontSize variable * Creating new header title style * Moving title into Stacktrace container * Updated snapshots
* Adding fontSize from variables * SectionHeader style added * Adding section headers Needed titling for DB statement and Stacktrace on the page * Pluralization * Adding fontSize variable * Creating new header title style * Moving title into Stacktrace container * Updated snapshots
Fixes #18184
Adding titles for DB statement and stacktrace on the Span details modal.