Repository navigation
[Visualize] Fix embeddable panel title behavior - #200548
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
approved these changes
Nov 18, 2024
Contributor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR adds a fix for a regression bug introduced with the new embeddable refactor in 8.16 . I've added an extra 8.16 FTR test to ensure it works. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 5102b50)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR adds a fix for a regression bug introduced with the new embeddable refactor in 8.16 . I've added an extra 8.16 FTR test to ensure it works. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 5102b50)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Visualize] Fix embeddable panel title behavior (#200548)](#200548) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-18T15:33:30Z","message":"[Visualize] Fix embeddable panel title behavior (#200548)\n\n## Summary\r\n\r\nThis PR adds a fix for a regression bug introduced with the new\r\nembeddable refactor in 8.16 .\r\nI've added an extra 8.16 FTR test to ensure it works.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5102b504890ccdc3b6632e6fe0f39e87ee82b653","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","v9.0.0","Feature:Embeddables","backport:version","v8.17.0","v8.16.1"],"title":"[Visualize] Fix embeddable panel title behavior","number":200548,"url":"https://github.com/elastic/kibana/pull/200548","mergeCommit":{"message":"[Visualize] Fix embeddable panel title behavior (#200548)\n\n## Summary\r\n\r\nThis PR adds a fix for a regression bug introduced with the new\r\nembeddable refactor in 8.16 .\r\nI've added an extra 8.16 FTR test to ensure it works.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5102b504890ccdc3b6632e6fe0f39e87ee82b653"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200548","number":200548,"mergeCommit":{"message":"[Visualize] Fix embeddable panel title behavior (#200548)\n\n## Summary\r\n\r\nThis PR adds a fix for a regression bug introduced with the new\r\nembeddable refactor in 8.16 .\r\nI've added an extra 8.16 FTR test to ensure it works.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5102b504890ccdc3b6632e6fe0f39e87ee82b653"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
…0592) # Backport This will backport the following commits from `main` to `8.16`: - [[Visualize] Fix embeddable panel title behavior (#200548)](#200548) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-18T15:33:30Z","message":"[Visualize] Fix embeddable panel title behavior (#200548)\n\n## Summary\r\n\r\nThis PR adds a fix for a regression bug introduced with the new\r\nembeddable refactor in 8.16 .\r\nI've added an extra 8.16 FTR test to ensure it works.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5102b504890ccdc3b6632e6fe0f39e87ee82b653","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","v9.0.0","Feature:Embeddables","backport:version","v8.17.0","v8.16.1"],"title":"[Visualize] Fix embeddable panel title behavior","number":200548,"url":"https://github.com/elastic/kibana/pull/200548","mergeCommit":{"message":"[Visualize] Fix embeddable panel title behavior (#200548)\n\n## Summary\r\n\r\nThis PR adds a fix for a regression bug introduced with the new\r\nembeddable refactor in 8.16 .\r\nI've added an extra 8.16 FTR test to ensure it works.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5102b504890ccdc3b6632e6fe0f39e87ee82b653"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200548","number":200548,"mergeCommit":{"message":"[Visualize] Fix embeddable panel title behavior (#200548)\n\n## Summary\r\n\r\nThis PR adds a fix for a regression bug introduced with the new\r\nembeddable refactor in 8.16 .\r\nI've added an extra 8.16 FTR test to ensure it works.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"5102b504890ccdc3b6632e6fe0f39e87ee82b653"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
## Summary This PR adds a fix for a regression bug introduced with the new embeddable refactor in 8.16 . I've added an extra 8.16 FTR test to ensure it works. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary This PR adds a fix for a regression bug introduced with the new embeddable refactor in 8.16 . I've added an extra 8.16 FTR test to ensure it works. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a fix for a regression bug introduced with the new embeddable refactor in 8.16 .
I've added an extra 8.16 FTR test to ensure it works.
Checklist