Skip to content

[Synthetics] Fix location filter in status rule executor - #215514

Merged
cesco-f merged 3 commits into
elastic:mainfrom
cesco-f:fix-location-filter
Mar 26, 2025
Merged

cesco-f merged 3 commits into
elastic:mainfrom
cesco-f:fix-location-filter

Conversation

@cesco-f

@cesco-f cesco-f commented Mar 21, 2025 •

Copy link
Copy Markdown
Contributor

This PR closes #215505 by fixing the location filter when creating a custom status rule for monitors.

Screen.Recording.2025-03-21.at.15.39.08.mov

@cesco-f
cesco-f marked this pull request as ready for review March 21, 2025 14:42
@cesco-f
cesco-f requested a review from a team as a code owner March 21, 2025 14:42
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@cesco-f
cesco-f force-pushed the fix-location-filter branch from 4285eca to de57b28 Compare March 24, 2025 07:43
@cesco-f
cesco-f force-pushed the fix-location-filter branch from de57b28 to 0ae4790 Compare March 26, 2025 10:56

@shahzad31 shahzad31 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@cesco-f
cesco-f enabled auto-merge (squash) March 26, 2025 14:06
@cesco-f
cesco-f merged commit 04d53ec into elastic:main Mar 26, 2025
@kibanamachine

Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14088086631

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 986.2KB 986.3KB +96.0B

History

@kibanamachine

Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts
❌ 8.18 Backport failed because of merge conflicts
❌ 8.x Backport failed because of merge conflicts
❌ 9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 215514

Questions ?

Please refer to the Backport tool documentation

@cesco-f

cesco-f commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

💔 Some backports could not be created

Status Branch Result
✅ 9.0
❌ 8.x An unhandled error occurred. Please see the logs for details
✅ 8.18
✅ 8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 215514

Questions ?

Please refer to the Backport tool documentation

@cesco-f

cesco-f commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cesco-f added a commit to cesco-f/kibana that referenced this pull request Mar 27, 2025
)

This PR closes elastic#215505 by fixing the location filter when creating a
custom status rule for monitors.

https://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062

---------

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
(cherry picked from commit 04d53ec)

# Conflicts:
#	x-pack/solutions/observability/plugins/synthetics/server/routes/common.ts
cesco-f added a commit to cesco-f/kibana that referenced this pull request Mar 27, 2025
)

This PR closes elastic#215505 by fixing the location filter when creating a
custom status rule for monitors.

https://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062

---------

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
(cherry picked from commit 04d53ec)

# Conflicts:
#	x-pack/solutions/observability/plugins/synthetics/server/routes/common.ts
cesco-f added a commit to cesco-f/kibana that referenced this pull request Mar 27, 2025
)

This PR closes elastic#215505 by fixing the location filter when creating a
custom status rule for monitors.

https://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062

---------

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
(cherry picked from commit 04d53ec)

# Conflicts:
#	x-pack/plugins/observability_solution/synthetics/server/routes/common.ts
#	x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/alerts/status_rule_viz.tsx
#	x-pack/solutions/observability/plugins/synthetics/server/routes/overview_status/overview_status_service.ts
cesco-f added a commit to cesco-f/kibana that referenced this pull request Mar 27, 2025
)

This PR closes elastic#215505 by fixing the location filter when creating a
custom status rule for monitors.

https://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062

---------

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
cesco-f added a commit that referenced this pull request Mar 27, 2025
…) (#216082)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Synthetics] Fix location filter in status rule executor
(#215514)](#215514)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-03-26T16:08:25Z","message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v8.17.5"],"title":"[Synthetics]
Fix location filter in status rule
executor","number":215514,"url":"https://github.com/elastic/kibana/pull/215514","mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x","8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215514","number":215514,"mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
cesco-f added a commit that referenced this pull request Mar 27, 2025
…) (#216086)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fix location filter in status rule executor
(#215514)](#215514)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-03-26T16:08:25Z","message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v8.17.5"],"title":"[Synthetics]
Fix location filter in status rule
executor","number":215514,"url":"https://github.com/elastic/kibana/pull/215514","mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216082","number":216082,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215514","number":215514,"mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216083","number":216083,"state":"OPEN"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216084","number":216084,"state":"OPEN"}]}]
BACKPORT-->
cesco-f added a commit that referenced this pull request Mar 27, 2025
) (#216084)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Synthetics] Fix location filter in status rule executor
(#215514)](#215514)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-03-26T16:08:25Z","message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v8.17.5"],"title":"[Synthetics]
Fix location filter in status rule
executor","number":215514,"url":"https://github.com/elastic/kibana/pull/215514","mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x","8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215514","number":215514,"mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
cesco-f added a commit that referenced this pull request Mar 27, 2025
) (#216083)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Synthetics] Fix location filter in status rule executor
(#215514)](#215514)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-03-26T16:08:25Z","message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v8.17.5"],"title":"[Synthetics]
Fix location filter in status rule
executor","number":215514,"url":"https://github.com/elastic/kibana/pull/215514","mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x","8.18","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215514","number":215514,"mergeCommit":{"message":"[Synthetics]
Fix location filter in status rule executor (#215514)\n\nThis PR closes
#215505 by fixing the location filter when creating a\ncustom status
rule for
monitors.\n\n\n\nhttps://github.com/user-attachments/assets/623b21fb-af45-42ae-a120-e38562451062\n\n---------\n\nCo-authored-by:
Shahzad
<shahzad31comp@gmail.com>","sha":"04d53ec134272fe111bf5553a0f1622418f75f71"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Synthetics] Location filter when creating a status rule not working as expected

4 participants