Skip to content

[Monitoring] Remove node_resolver Setting - #21181

Merged
pickypg merged 3 commits into
elastic:masterfrom
pickypg:breaking/remove-deprecated-setting
Jul 27, 2018
Merged

pickypg merged 3 commits into
elastic:masterfrom
pickypg:breaking/remove-deprecated-setting

Conversation

@pickypg

@pickypg pickypg commented Jul 24, 2018

Copy link
Copy Markdown
Member

This is a breaking change that removes the xpack.monitoring.node_resolver setting. This setting was deprecated in 5.6, and in 6.1 the setting was limited to uuid explicitly. Beginning in 7.0, after this is merged, the setting will no longer exist.

Closes #21095

This is a breaking change that removes the
`xpack.monitoring.node_resolver` setting. This setting was deprecated in
5.6, and in 6.1 the setting was limited to `uuid` explicitly. Beginning in
7.0, after this is merged, the setting will no longer exist.
@pickypg
pickypg requested review from chrisronline and lcawl July 24, 2018 21:59
Comment thread docs/migration/migrate_7_0.asciidoc Outdated
=== Deprecated kibana.yml setting `xpack.monitoring.node_resolver` has been removed
*Details:* This setting has been deprecated since 5.6, when it was explicitly recommended to use `uuid` as its value.

*Impact:* The setting is no longer needed to use the best way to determine node uniqueness, its persistent UUID. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to clarify the impact with something like this (stolen from https://www.elastic.co/guide/en/kibana/6.3/xpack-monitoring.html):

This setting is no longer necessary. If you enable {monitoring} across the Elastic Stack, a monitoring agent runs on each Elasticsearch node, Logstash node, Kibana instance, and Beat to collect and index metrics. Each node and instance is considered unique based on its persistent UUID, which is written to the path.data directory when the node or instance starts.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@lcawl lcawl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation changes LGTM

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@chrisronline chrisronline left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pickypg
pickypg merged commit 30d4e70 into elastic:master Jul 27, 2018
@pickypg
pickypg deleted the breaking/remove-deprecated-setting branch July 27, 2018 21:42
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
This is a breaking change that removes the
`xpack.monitoring.node_resolver` setting. This setting was deprecated in
5.6, and in 6.1 the setting was limited to `uuid` explicitly. Beginning in
7.0, after this is merged, the setting will no longer exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Monitoring] Remove node_resolver settings

4 participants