Repository navigation
[Lens] fix drag and drop ghost after Chrome update to 134 - #213928
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
approved these changes
Mar 11, 2025
markov00
left a comment
Contributor
There was a problem hiding this comment.
Tested locally, works perfectly, thanks
akowalska622
approved these changes
Mar 11, 2025
akowalska622
left a comment
Contributor
There was a problem hiding this comment.
Awesome investigation!
nickofthyme
approved these changes
Mar 11, 2025
nickofthyme
left a comment
Contributor
There was a problem hiding this comment.
Tested and works great!
Contributor
|
Hi team, |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
nickofthyme
added a commit
that referenced
this pull request
Mar 21, 2025
## Summary Fixes #213324 For some reason this PR #213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
nickofthyme
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
nickofthyme
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
nickofthyme
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
nickofthyme
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
nickofthyme
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 22, 2025
) (#214127) # Backport This will backport the following commits from `main` to `9.0`: - #213928 - #215439 <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T11:30:51Z","message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:prev-major","Feature:UnifiedFieldList","v9.1.0"],"title":"[Lens] fix drag and drop ghost after Chrome update to 134","number":213928,"url":"https://github.com/elastic/kibana/pull/213928","mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213928","number":213928,"mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}}]}] BACKPORT--> --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 22, 2025
…3928) (#214123) # Backport This will backport the following commits from `main` to `8.16`: - #213928 - #215439 <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T11:30:51Z","message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:prev-major","Feature:UnifiedFieldList","v9.1.0"],"title":"[Lens] fix drag and drop ghost after Chrome update to 134","number":213928,"url":"https://github.com/elastic/kibana/pull/213928","mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213928","number":213928,"mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}}]}] BACKPORT--> --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 22, 2025
…3928) (#214124) # Backport This will backport the following commits from `main` to `8.17`: - #213928 - #215439 <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T11:30:51Z","message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:prev-major","Feature:UnifiedFieldList","v9.1.0"],"title":"[Lens] fix drag and drop ghost after Chrome update to 134","number":213928,"url":"https://github.com/elastic/kibana/pull/213928","mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213928","number":213928,"mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}}]}] BACKPORT--> --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 22, 2025
) (#214126) # Backport This will backport the following commits from `main` to `8.x`: - #213928 - #215439 <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T11:30:51Z","message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:prev-major","Feature:UnifiedFieldList","v9.1.0"],"title":"[Lens] fix drag and drop ghost after Chrome update to 134","number":213928,"url":"https://github.com/elastic/kibana/pull/213928","mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213928","number":213928,"mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}}]}] BACKPORT--> --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 22, 2025
…3928) (#214125) # Backport This will backport the following commits from `main` to `8.18`: - #213928 - #215439 <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T11:30:51Z","message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:prev-major","Feature:UnifiedFieldList","v9.1.0"],"title":"[Lens] fix drag and drop ghost after Chrome update to 134","number":213928,"url":"https://github.com/elastic/kibana/pull/213928","mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213928","number":213928,"mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}}]}] BACKPORT--> --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
Contributor
|
This PR didn't land on time for the latest 8.17.4 and 8.16.6 BC. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #213708
Fixes the ghost display. As @nickofthyme pointed out here, the reason was using inset-inline-start: -10000px for the keyboard handler that is one of the children of the draggable component. The quick fix is to just move it outside of the html element that is dragged. @markov00 please assesswhere it should be merged 🙏🏼