Repository navigation
fix(slo): use wildcard remote when useAllRemoteClusters is true - #224478
Merged
Merged
Conversation
kdelemme
marked this pull request as ready for review
June 18, 2025 17:06
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 19, 2025
…tic#224478) ### 🍒 Summary resolves elastic#224476 This PR changes how the summary indices are constructed when remote clusters is enabled. When `useAllRemoteCluster` is true, we simply use `*:summary-index` instead of listing each remote individually. We also removed the need to fetch the remote clusters info when we use `useAllRemoteCluster`. ### Release notes Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes. (cherry picked from commit aac0893)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 19, 2025
#224478) (#224531) # Backport This will backport the following commits from `main` to `8.19`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
This was referenced Jun 19, 2025
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jun 19, 2025
…tic#224478) ### 🍒 Summary resolves elastic#224476 This PR changes how the summary indices are constructed when remote clusters is enabled. When `useAllRemoteCluster` is true, we simply use `*:summary-index` instead of listing each remote individually. We also removed the need to fetch the remote clusters info when we use `useAllRemoteCluster`. ### Release notes Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes. (cherry picked from commit aac0893) # Conflicts: # x-pack/solutions/observability/plugins/slo/common/summary_indices.test.ts # x-pack/solutions/observability/plugins/slo/common/summary_indices.ts # x-pack/solutions/observability/plugins/slo/server/services/slo_settings.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jun 19, 2025
…tic#224478) ### 🍒 Summary resolves elastic#224476 This PR changes how the summary indices are constructed when remote clusters is enabled. When `useAllRemoteCluster` is true, we simply use `*:summary-index` instead of listing each remote individually. We also removed the need to fetch the remote clusters info when we use `useAllRemoteCluster`. ### Release notes Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes. (cherry picked from commit aac0893) # Conflicts: # x-pack/plugins/observability_solution/slo/common/summary_indices.test.ts # x-pack/plugins/observability_solution/slo/server/services/slo_settings.ts # x-pack/solutions/observability/plugins/slo/common/get_slo_summary_indices.ts
kdelemme
added a commit
that referenced
this pull request
Jun 19, 2025
#224478) (#224581) # Backport This will backport the following commits from `main` to `8.17`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224531","number":224531,"state":"MERGED","mergeCommit":{"sha":"3590e18388bfe075c6158c8873e3c2f2be63a91f","message":"[8.19] fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478) (#224531)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [fix(slo): use wildcard remote when useAllRemoteClusters is true\n(#224478)](https://github.com/elastic/kibana/pull/224478)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Kevin Delemme <kevin.delemme@elastic.co>"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kdelemme
added a commit
that referenced
this pull request
Jun 19, 2025
…#224478) (#224577) # Backport This will backport the following commits from `main` to `9.0`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224531","number":224531,"state":"MERGED","mergeCommit":{"sha":"3590e18388bfe075c6158c8873e3c2f2be63a91f","message":"[8.19] fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478) (#224531)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [fix(slo): use wildcard remote when useAllRemoteClusters is true\n(#224478)](https://github.com/elastic/kibana/pull/224478)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Kevin Delemme <kevin.delemme@elastic.co>"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kdelemme
added a commit
that referenced
this pull request
Jun 19, 2025
#224478) (#224578) # Backport This will backport the following commits from `main` to `8.18`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224531","number":224531,"state":"MERGED","mergeCommit":{"sha":"3590e18388bfe075c6158c8873e3c2f2be63a91f","message":"[8.19] fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478) (#224531)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [fix(slo): use wildcard remote when useAllRemoteClusters is true\n(#224478)](https://github.com/elastic/kibana/pull/224478)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Kevin Delemme <kevin.delemme@elastic.co>"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Contributor
|
This PR didn't get it on time into the latest BC for v8.17.8, v8.18.3 and v9.0.3. Updating the labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍒 Summary
resolves #224476
This PR changes how the summary indices are constructed when remote clusters is enabled.
When
useAllRemoteClusteris true, we simply use*:summary-indexinstead of listing each remote individually.We also removed the need to fetch the remote clusters info when we use
useAllRemoteCluster.Release notes
Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes.