Skip to content

Adjust spacing of Management nav items so they're easier to differentiate when they contain wrapped lines #25666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjcenizal merged 1 commit into from
Nov 15, 2018
Merged

Adjust spacing of Management nav items so they're easier to differentiate when they contain wrapped lines #25666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/core_plugins/kibana/public/management/_management_app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,25 @@
background: $euiColorEmptyShade;
}

/**
* 1. Override kuiPanelBody styles to accommodate padding of items within the panel body..
*/
.mgtPanel__body {
padding: 5px 10px; /* 1 */
}

/**
* 1. Create vertical space between items when they wrap.
*/
.mgtPanel__item {
padding: 5px 15px; /* 1 */
}

// SASSTODO: Remove when this is replaced by the side nav
.mgtPanel__link {
@include euiFontSizeL;

line-height: 2; // Give some buffer for when they wrap
line-height: 1.5; // Make sure the space between wrapped lines is than the vertical space between items.

&.mgtPanel__link--disabled {
opacity: $euiColorDarkShade;
Expand Down Expand Up @@ -52,4 +66,4 @@ kbn-management-objects {
display: inline-block;
}
}
}
}
4 changes: 2 additions & 2 deletions src/core_plugins/kibana/public/management/landing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ <h3 class="kuiPanelHeader__title">
</div>
</div>

<div class="kuiPanelBody">
<div class="kuiPanelBody mgtPanel__body">
<div class="row">
<ul class="list-unstyled">
<li
class="col-xs-4 col-md-3"
class="col-xs-4 col-md-3 mgtPanel__item"
ng-repeat="item in section.visibleItems"
>
<a
Expand Down