Skip to content

Add en for numeral locale setting - #25948

Merged
timroes merged 1 commit into
elastic:masterfrom
timroes:en-numeral-locale
Nov 22, 2018
Merged

timroes merged 1 commit into
elastic:masterfrom
timroes:en-numeral-locale

Conversation

@timroes

@timroes timroes commented Nov 20, 2018 •

Copy link
Copy Markdown
Contributor

Summary

Fixes #22991, fixes #25793, Add en as a valid locale to the settings.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// kbn-management labels Nov 20, 2018
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@markov00 markov00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested on chrome/osx

@timroes
timroes merged commit bcb5ee0 into elastic:master Nov 22, 2018
@timroes
timroes deleted the en-numeral-locale branch November 22, 2018 09:12
timroes added a commit to timroes/kibana that referenced this pull request Nov 22, 2018
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New value added to drive a business result Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v6.6.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting locale defaults to non-existent value in Advanced settings Reset to default format:number:defaultLocale select a wrong default

3 participants