You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add rest_total_hits_as_int into Kibana App - #26404
This will add rest_total_hits_as_int: true to all requests in Kibana App code, where we later potentially call hits.total on. This includes the following places:
Courier (Rollup and default search strategy)
TSVB (all requests, though I think we actually call hits.total not on all results, but better being safe than sorry)
Graph (in the place we read out hits.total later)
Reporting
Unfortunately those changes are not testable right now :-(
The PR should pass, since the parameter is accepted (but has no effect) in ES right now. As soon as elastic/elasticsearch#35849 is merged, this PR should make sure, that the Kibana App code will still work against ES master. Unfortunately we can also not properly test it against that PR version, because even if I let this PR run against that PR in it's own branch (which our CI can), the tests will fail, because all other (non Kibana App) places, haven't adjusted to that parameter yet, and thus tests from ML, APM, etc. will just fail.
Checklist
Use strikethroughs to remove checklist items you don't feel are applicable to this PR.
Indeed. Should have the same issue, even though I couldn't see hits.total being accessed directly anywhere, but will dig a bit deeper, to see where it's accessed and fix that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markov00
left a comment
Summary
Implements Step 1 of #26356.
This will add
rest_total_hits_as_int: trueto all requests in Kibana App code, where we later potentially callhits.totalon. This includes the following places:hits.totalnot on all results, but better being safe than sorry)hits.totallater)Unfortunately those changes are not testable right now :-(
The PR should pass, since the parameter is accepted (but has no effect) in ES right now. As soon as elastic/elasticsearch#35849 is merged, this PR should make sure, that the Kibana App code will still work against ES master. Unfortunately we can also not properly test it against that PR version, because even if I let this PR run against that PR in it's own branch (which our CI can), the tests will fail, because all other (non Kibana App) places, haven't adjusted to that parameter yet, and thus tests from ML, APM, etc. will just fail.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately