Skip to content

Better fix for page preview size issue - #26795

Merged
cqliu1 merged 1 commit into
elastic:masterfrom
cqliu1:fix/page-preview-thumbnails
Dec 12, 2018
Merged

cqliu1 merged 1 commit into
elastic:masterfrom
cqliu1:fix/page-preview-thumbnails

Conversation

@cqliu1

@cqliu1 cqliu1 commented Dec 7, 2018 •

Copy link
Copy Markdown
Contributor

Closes #26562.

This applies the global workpad CSS styles closer to the page previews and allows me to remove the additional div in the previous implementation. The additional div appears to be the cause of the original bug.

@cqliu1
cqliu1 requested a review from ryankeairns December 7, 2018 06:17
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@cqliu1
cqliu1 requested review from w33ble and removed request for ryankeairns December 11, 2018 20:47
@cqliu1
cqliu1 force-pushed the fix/page-preview-thumbnails branch from 6a544dc to 1f1baf9 Compare December 11, 2018 20:56
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@w33ble

w33ble commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Before:

screenshot 2018-12-12 13 49 43

After:

screenshot 2018-12-12 14 06 15

@w33ble w33ble left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w33ble

w33ble commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

@cqliu1 make sure you add some version labels to this pr, and backport appropriately.

@cqliu1 cqliu1 added review v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.6.0 labels Dec 12, 2018
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas

@cqliu1
cqliu1 merged commit e118030 into elastic:master Dec 12, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 12, 2018
@cqliu1
cqliu1 deleted the fix/page-preview-thumbnails branch December 12, 2018 21:38
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.6.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page selector only shows first page

3 participants