Skip to content

upgrade resize-observer-polyfill version - #26929

Closed
mw-ding wants to merge 1 commit into
elastic:masterfrom
mw-ding:master
Closed

mw-ding wants to merge 1 commit into
elastic:masterfrom
mw-ding:master

Conversation

@mw-ding

@mw-ding mw-ding commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

Summary

We are currently resolving the typescript type check error and some deps errors while trying to merge the code repo.

There is a couple of errors related with resize-observer-polyfill but not in code codebase. This change fixes these errors.

The version of resize-observer-polyfill in kibana root is not aligned with the one in x-pack folder.

@mw-ding
mw-ding requested a review from spalger December 10, 2018 22:55
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@spalger spalger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green!

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@mw-ding

mw-ding commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

test this

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@mw-ding

mw-ding commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

test this

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@mw-ding

mw-ding commented Dec 11, 2018 •

Copy link
Copy Markdown
Contributor Author

close this PR to move to a different branch in my local forked repository other than master

new PR here: #26990

@mw-ding mw-ding closed this Dec 11, 2018
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants