Skip to content

[WIP] visualizations field formatting refactoring - #26951

Closed
ppisljar wants to merge 49 commits into
elastic:masterfrom
ppisljar:pipeline/fieldFormattingPoC
Closed

[WIP] visualizations field formatting refactoring#26951
ppisljar wants to merge 49 commits into
elastic:masterfrom
ppisljar:pipeline/fieldFormattingPoC

Conversation

@ppisljar

@ppisljar ppisljar commented Dec 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

handling field formatting in the expressions

  • all visualizations now get formatting options passed in as part of the configuration
  • vislib charts no longer require aggConfig information
  • legacy response handler now only does table splitting and doesn't require aggConfigs
  • point series response handler now builds directly on top of tabify table and doesn't require aggConfigs
  • hierarchical response handler now builds directly on top of tabify table and doesn't require aggConfigs

todo:

  • cleanup
  • tests

@ppisljar ppisljar added discuss Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Dec 11, 2018
@elasticmachine

elasticmachine commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app

@elasticmachine

elasticmachine commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

💔 Build Failed

@timroes timroes mentioned this pull request Dec 12, 2018
Closed
47 of 58 tasks
@ppisljar ppisljar added WIP Work in progress v7.0.0 and removed discuss labels Dec 20, 2018
@ppisljar
ppisljar force-pushed the pipeline/fieldFormattingPoC branch from 07e2141 to 5c53d79 Compare December 20, 2018 11:44
@elasticmachine

elasticmachine commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

💔 Build Failed

@ppisljar ppisljar changed the title field formatting PoC [WIP] field formatting refactoring Dec 20, 2018
@ppisljar ppisljar changed the title [WIP] field formatting refactoring [WIP] visualizations field formatting refactoring Dec 20, 2018
lukeelmers
lukeelmers reviewed Dec 21, 2018
View reviewed changes

@lukeelmers lukeelmers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial cursory read of the code. Still need to look at changes to build_pipeline.ts and do some testing once the PR is ready.

Comment thread src/legacy/core_plugins/metric_vis/public/metric_vis_controller.js Outdated
Comment thread src/ui/public/vis/vis_filters.js Outdated
@elasticmachine

elasticmachine commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

💔 Build Failed

@lukeelmers lukeelmers mentioned this pull request Dec 21, 2018
Closed
3 tasks done
@lukeelmers lukeelmers mentioned this pull request Jan 2, 2019
Merged
8 tasks done
@ppisljar
ppisljar force-pushed the pipeline/fieldFormattingPoC branch from 8919029 to 55b4097 Compare January 7, 2019 09:00
@elasticmachine

elasticmachine commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@ppisljar
ppisljar force-pushed the pipeline/fieldFormattingPoC branch 3 times, most recently from df69d3e to 1ea63c6 Compare January 7, 2019 12:34
@elasticmachine

elasticmachine commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@ppisljar
ppisljar force-pushed the pipeline/fieldFormattingPoC branch from c85db64 to 6d16207 Compare January 14, 2019 13:07
@elasticmachine

elasticmachine commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@ppisljar

ppisljar commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

closing in favor of #28746

@ppisljar ppisljar closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers lukeelmers left review comments
@timroes timroes Awaiting requested review from timroes
@markov00 markov00 Awaiting requested review from markov00

Assignees

No one assigned

Labels

Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.0.0 WIP Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ppisljar @elasticmachine @lukeelmers