Repository navigation
Rewrite URL when closing vis type selection modal - #26327
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
cjcenizal
approved these changes
Nov 28, 2018
cjcenizal
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Tested locally, code review.
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Nov 29, 2018
timroes
added a commit
that referenced
this pull request
Nov 29, 2018
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26230
The empty state no longer will redirect to the
/visualize/newURL, but instead load the new vis modal in place.Also when you navigate to the URL, and close the dialog, the URL will now change to
/visualize. This will actually refresh the route. Since the URL is scheduled for removal, I think it's not worth messing with the window history at this place (and thus need to build URLs manually), but we can just rely onkbnUrlservice instead.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately