Skip to content

[Monitoring] Do not use the normalized derivative value - #27416

Merged
chrisronline merged 2 commits into
elastic:masterfrom
chrisronline:monitoring/cpu_math
Dec 21, 2018
Merged

chrisronline merged 2 commits into
elastic:masterfrom
chrisronline:monitoring/cpu_math

Conversation

@chrisronline

Copy link
Copy Markdown
Contributor

Relates to elastic/beats#9377

This PR updates the math used to calculate CPU utilization to not use the normalized derivative value, but instead use the default value. In this situation, it seems the normalized derivative (read docs here) is not what the user expects to see as the % values will not match what their system is reporting.

See the beats issue for reproduction steps.

@chrisronline chrisronline self-assigned this Dec 18, 2018
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/stack-monitoring

@chrisronline

Copy link
Copy Markdown
Contributor Author

cc @pickypg

@ycombinator ycombinator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally LGTM. Elegant fix!

@chrisronline
chrisronline merged commit 81511dd into elastic:master Dec 21, 2018
@chrisronline
chrisronline deleted the monitoring/cpu_math branch December 21, 2018 15:57
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* Use the non normalized value

* Update keys used in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants