Skip to content

Fixes PropType error in toggle arg - #27514

Merged
cqliu1 merged 1 commit into
elastic:masterfrom
cqliu1:fix/toggle-arg
Dec 19, 2018
Merged

cqliu1 merged 1 commit into
elastic:masterfrom
cqliu1:fix/toggle-arg

Conversation

@cqliu1

@cqliu1 cqliu1 commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

Closes #27451.

This adds an early return to the toggle arg when it receives a non-boolean value instead of trying to render the EuiSwitch component before falling back to the expression arg form.

@cqliu1
cqliu1 requested a review from a team as a code owner December 19, 2018 17:08
@cqliu1 cqliu1 added review v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.6.0 labels Dec 19, 2018
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 added the v6.5.5 label Dec 19, 2018
@cqliu1
cqliu1 requested a review from w33ble December 19, 2018 17:11

@w33ble w33ble left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@cqliu1
cqliu1 merged commit 2759e35 into elastic:master Dec 19, 2018
@cqliu1
cqliu1 deleted the fix/toggle-arg branch December 19, 2018 17:48
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
@cqliu1 cqliu1 added the v6.7.0 label Dec 19, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 20, 2018
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 21, 2018
@cqliu1
cqliu1 restored the fix/toggle-arg branch January 3, 2019 16:09
@cqliu1
cqliu1 deleted the fix/toggle-arg branch January 3, 2019 16:32
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.5.5 v6.6.0 v6.7.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants