Repository navigation
fixing some validation issues with edit policy - #27045
Merged
Merged
Conversation
Contributor
💚 Build Succeeded |
loixlab
approved these changes
Dec 12, 2018
loixlab
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Tested locally and works great.
Contributor
💚 Build Succeeded |
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Dec 12, 2018
* fixing validation issues with editing existing policy * preventing less than 1 values for max size and max age and adding tests
bmcconaghy
added a commit
that referenced
this pull request
Dec 12, 2018
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* fixing validation issues with editing existing policy * preventing less than 1 values for max size and max age and adding tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a couple of issues with saving a policy, going into edit, trying to save the same policy. It was failing on validating minimum age for hot phase (now skipped) and also failing on duplicate name detection (now only invoked if original policy name does not match current name). Tested scenarios in browser to validate.