Repository navigation
Fix dashboard to refresh visualizations when the refresh button is clicked - #27260
lukasolson wants to merge 1 commit into
Conversation
|
Pinging @elastic/kibana-app |
💔 Build Failed |
|
Looks like I need to update some tests and add one to test this behavior. |
💔 Build Failed |
I personally like the idea of having an explicit I am not yet familar enough with the dashboard code, to check if that's a good way to keep track of all the embeddables. Maybe @stacey-gammon could elaborate on that part of the code a bit? |
|
The embeddables are all stored on the redux tree, so if you add a RELOAD action, I think you can do this without the registering/deregistering stuff, and I think without $scope.reload. @lukasolson - lmk if you want to sync up and go over to see if we can do this without any extra angular stuff. |
|
Closed in favor of #27353. |
Summary
Fixes #23329.
This PR updates dashboard so that clicking on the refresh button actually refreshes visualizations.
As of #19172, visualizations don't inherit from the dashboard's search source. As a result, when the search source is updated (even when clicking on the "refresh" button), they don't automatically get the new data that's fetched.
This PR adds an additional property to some of the dashboard components that allows parent components to call
reload()programmatically, rather than only when state changes happen.Honestly I'm not too thrilled with this change, so I'm open to feedback about other ways we could accomplish this same thing. As far as I could tell the only mechanism for communication between the panels and the dashboard was via state changes.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately