Repository navigation
Fix confirm overwrite modal of saved objects to handle large titles - #28590
Merged
mikecote merged 1 commit intoJan 17, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 17, 2019
mikecote
added a commit
that referenced
this pull request
Jan 17, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25030.
This PR fixes the issue when importing saved objects with long titles. Some of the text hides under the "X" in the top right corner of the confirm overwrite modal. The approach I used is to add a title to the modals based on recommendation in #25030.
Before:
After:
Checklist
- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers