Repository navigation
Removing deprecated SSL settings - #28622
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-security |
Contributor
💔 Build Failed |
Contributor
|
Looks like CI failures are legit |
azasypkin
approved these changes
Jan 14, 2019
azasypkin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with a green CI.
| [float] | ||
| === kibana.yml setting `server.ssl.enabled` must be set to `true` to enable SSL | ||
| *Details:* Previously, if `server.ssl.certificate` and `server.ssl.key` were set, SSL would automatically be enabled. | ||
| It's now required that the user set `server.ssl.enabled` to true for this to occur. |
Contributor
There was a problem hiding this comment.
typo: the user set --> the user sets?
Contributor
Author
Yeah... I forgot to update the tests, lemme do so here shortly. |
legrego
approved these changes
Jan 14, 2019
legrego
left a comment
Member
There was a problem hiding this comment.
Optional docs update, otherwise LGTM pending green CI!
Co-Authored-By: kobelb <brandon.kobel@gmail.com>
Contributor
💚 Build Succeeded |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Removing deprecated SSL settings * Updating breaking changes doc * Fixing documentation typo * Fixing LegacyObjectToConfigAdapter tests * Fixing transformDeprecations tests * Updating docs Co-Authored-By: kobelb <brandon.kobel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the ability to automatically enable SSL by only setting
server.ssl.certificateandserver.ssl.key, you're now required to setserver.ssl.enabled. This has been deprecated for a while now.This also removes the ability to use
server.ssl.certand requires that the user useserver.ssl.certificate. This has also been deprecated for a while."Release Note:
server.ssl.enabledmust be explicitly set to enable https for the Kibana server.""Release Note:
server.ssl.certis no longer valid,server.ssl.certificatemust be used instead."