Skip to content

Remove legacy response handler - #28985

Merged
timroes merged 1 commit into
elastic:masterfrom
timroes:remove-legacy-resphandler
Jan 21, 2019
Merged

timroes merged 1 commit into
elastic:masterfrom
timroes:remove-legacy-resphandler

Conversation

@timroes

@timroes timroes commented Jan 18, 2019

Copy link
Copy Markdown
Contributor

Summary

Remove the legacy response handler as a response handler. It will keep the class since it's used in more places as a utility (mainly table vis expression function and the vislib response handler). As soon as we have the new table implementation we can move that over as a pure utility function to the vislib response handler.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Dev-Docs

Remove legacy response handler

Remove the already deprecated legacy response handler for visualizations. See Kibana Plugin API changes in 6.5 for more information.

@timroes timroes added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:deprecation v7.0.0 release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Jan 18, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app

@timroes timroes mentioned this pull request Jan 18, 2019
3 of 4 tasks
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@ppisljar ppisljar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes
timroes merged commit b2f1cc4 into elastic:master Jan 21, 2019
@timroes
timroes deleted the remove-legacy-resphandler branch January 21, 2019 08:04
@timroes timroes mentioned this pull request Mar 5, 2019
2 tasks done
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:deprecation release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants