Repository navigation
Monitoring design touchup - #29479
Conversation
chrisronline
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this!
|
Pinging @elastic/stack-monitoring |
|
Pinging @elastic/kibana-design |
|
@ryankeairns I'll give a look very soon, but were you also able to tackle #19439? |
snide
left a comment
There was a problem hiding this comment.
Changes in here look good and are mergeable as is. So go for it.
--
Here are some other small bits I bet we could change to clean things up a bit in either this PR or a later one.
Some text cleanup in the tables to account for wrapping.
There are lots of tables would be better off using pure empty state messages rather than dead tables.
I bet the text can be rearranged / resized here a little better so that it reads a little more concise. Likely using some stacking so the columns don't end up so wide will give everything a little more room and fix a lot of the wrapping issues.
|
@cchaos I'll take a look at that issue, thanks for pointing it out. |
5b4bcdd to
33d8bbb
Compare
cchaos
left a comment
There was a problem hiding this comment.
I mainly just saw a couple of issues on IE:
Responsive is a bit jacked up and the titles for the graphs overlap the graphs:
💔 Build Failed |
|
Working on the titles now, just noticed that when tackling the shards issue. I wasn't sure what to use for icons there... Monitoring has 3 levels/states and each just had a dot that looked like a bullet point which struck me as a formatting error. I'm game for whatever icons. As is stands, I have it set to: |
💔 Build Failed |
💔 Build Failed |
42113a3 to
1c213e9
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
The above feedback has been addressed other than the IE11 layout issues on smaller screen sizes. I've captured it in this issue #29758 to be worked as a separate PR. |
* UI design touchup for 7.0 * clean up chart titles and beta icon * Make shard list wrap on IE11 * wrap table cells with much content * fix title height above graphs on ie11 * update tests and snapshots * update functional test for node detail * fixing more functional tests
* UI design touchup for 7.0 * clean up chart titles and beta icon * Make shard list wrap on IE11 * wrap table cells with much content * fix title height above graphs on ie11 * update tests and snapshots * update functional test for node detail * fixing more functional tests
* UI design touchup for 7.0 * clean up chart titles and beta icon * Make shard list wrap on IE11 * wrap table cells with much content * fix title height above graphs on ie11 * update tests and snapshots * update functional test for node detail * fixing more functional tests
Fixes #19439
Summary
The Kibana Design team is combing through the apps bringing them all more into alignment by cleaning up styles and markup. This PR is largely polish - tidying up some EUI flex layouts, spacing, etc.
The most noticeable visual changes are 1) setting the main over page panels to not stretch across the page and 2) separating the stats summary atop each sub page from the charts/tables below them. The purpose of both is to make things more easily scannable.
Main overview
Stats summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers