Skip to content

[Canvas] Fix: keep element selection after layer move up/down - #29634

Merged
monfera merged 1 commit into
masterfrom
dont-deselect-on-z-reorder
Jan 30, 2019
Merged

monfera merged 1 commit into
masterfrom
dont-deselect-on-z-reorder

Conversation

@monfera

@monfera monfera commented Jan 30, 2019 •

Copy link
Copy Markdown
Contributor

Summary

When selecting an element and using the ⬆️ ⬇️ ⏫ ⏬ z-layering operations, the element selection shouldn't be lost. New operation:

selected

Closes #23019. Needed by #29394.

@monfera monfera added review v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// labels Jan 30, 2019
@monfera monfera self-assigned this Jan 30, 2019
@monfera
monfera requested a review from cqliu1 January 30, 2019 17:43
@monfera
monfera requested a review from a team as a code owner January 30, 2019 17:43
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Confirmed changed the layer position doesn't deselect the element anymore.
jan-30-2019 12-23-49

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.6.1 v6.7.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants