Repository navigation
[dashboard+gis] remove dark mode options - #29017
Conversation
|
Pinging @elastic/kibana-gis |
|
Pinging @elastic/kibana-app |
| // Visual builder applies dark theme by investigating appState for 'options.darkTheme' | ||
| // This test ensures everything is properly wired together and Visual Builder adds dark theme classes | ||
| it('should display Visual Builder timeseries with reversed class', async () => { | ||
| await dashboardAddPanel.addVisualization('Rendering Test: tsvb-ts'); |
There was a problem hiding this comment.
| <Visualization | ||
| dateFormat={this.props.config.get('dateFormat')} | ||
| reversed={reversed} | ||
| reversed={false} |
There was a problem hiding this comment.
Will base this value on the dark mode uiSetting in #28445
There was a problem hiding this comment.
💚 Build Succeeded |
cchaos
left a comment
There was a problem hiding this comment.
There's still about 17 references of .theme-dark like in the _hacks.scss file:
Should these be removed as well?
💚 Build Succeeded |
cchaos
left a comment
There was a problem hiding this comment.
LGTM. I made some notes to myself to double-check when universal dark theme goes in.
thomasneirynck
left a comment
There was a problem hiding this comment.
verified in maps app. thank you 🙇♂️ !
|
Side note: Is this or the other PR going to be labeled as blocker, seeing as how existing dark themed dashboards are going to not be dark theme any more? |
|
I assume you mean "breaking"? I suppose this one should be, but yeah, need to add a release note to this one. |
|
Hahaha yes I mean breaking change. Words are so very difficult. |
|
@spalger Could you please add a description of this change to the Breaking Changes doc? |
|
Updated breaking changes doc in 7728d11 |
* [dashboard+gis] remove dark mode options * [reporting/extract] restore fixtures * remove mentions of old `.theme-dark` class * import panel styles from panel/_index.scss
Summary
In Kibana 7 we will be removing the app-specific dark mode options and replacing them with a global dark mode uiSetting. #28445 will add the new uiSetting, but I wanted to split up the work a little so I'm starting with a removal of the dark theme settings from the Dashboard and GIS apps.
Visualize also passes a
reversedprop to visualizations that indicates if dark mode is in effect, and since with the PR I'm removing that ability I've hard coded that prop tofalseinsrc/legacy/core_plugins/metrics/public/components/vis_editor.js. With #28445 I'll start setting that value based on the uiSetting and update the tests to make sure functionality is not broken.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportThis was checked for keyboard-only and screenreader accessibilityFor maintainers
--
release-note: Dark mode is now a global option
You used to have to choose to which dashboards should use dark mode and which shouldn't, but starting in Kibana 7.0 this setting has been moved to the advanced settings and will apply to everything, not just Dashboards or the GIS app! This means that the dark mode setting in dashboards is now ignored and overridden by the global advanced setting.