Skip to content

Removes Unused react-toggle dependency. - #29086

Merged
tsullivan merged 2 commits into
elastic:masterfrom
varunsharma27:remove-unused-react-toggle
Mar 11, 2019
Merged

Removes Unused react-toggle dependency.#29086
tsullivan merged 2 commits into
elastic:masterfrom
varunsharma27:remove-unused-react-toggle

Conversation

@varunsharma27

@varunsharma27 varunsharma27 commented Jan 22, 2019

Copy link
Copy Markdown
Contributor

Removes Unused react-toggle dependency.

@elasticmachine

elasticmachine commented Jan 22, 2019

Copy link
Copy Markdown
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@varunsharma27 varunsharma27 mentioned this pull request Feb 27, 2019
Closed
@tsullivan
tsullivan self-requested a review March 4, 2019 18:49
@tsullivan

tsullivan commented Mar 4, 2019

Copy link
Copy Markdown
Member

jenkins test this

@elasticmachine

elasticmachine commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@varunsharma27

varunsharma27 commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Was that a flaky build?
The react-toggle stopped being used since this PR :-
https://github.com/elastic/kibana/pull/24250/files#diff-9d4d6ec060287056b0636184d20f8dfdL23

@tsullivan

tsullivan commented Mar 7, 2019

Copy link
Copy Markdown
Member

@varunsharma27

It looks like the build failed because removing the dependency from package.json affects the yarn.lock file, and CI expects that you've run yarn kbn bootstrap to make the changes to yarn.lock locally and commit those in the branch.

Would you mind merging master once again (your baseline is probably too out of date for a pass to be valid), do the yarn kbn bootstrap, commit the changes to yarn.lock and push them?

@tsullivan

tsullivan commented Mar 7, 2019

Copy link
Copy Markdown
Member

https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/3474/JOB=kibana-intake,node=immutable/console

That link will expire in a few days, but here's what I saw when I looked at the first ci group console output:

11:58:28 Bootstrapping completed!
11:58:28 
11:58:28 Done in 266.43s.
11:58:28 
11:58:28 ERROR: 'yarn kbn bootstrap' caused changes to the following files:
11:58:28 
11:58:28 yarn.lock
11:58:28 
11:58:28 runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
11:58:28 runbld>>> DURATION: 366113ms
11:58:28 runbld>>> STDOUT: 11167 bytes
11:58:28 runbld>>> STDERR: 843 bytes
11:58:28 runbld>>> WRAPPED PROCESS: FAILURE (1)

@varunsharma27
varunsharma27 force-pushed the remove-unused-react-toggle branch from 3a454b5 to 44bfb83 Compare March 8, 2019 10:29
@tsullivan

tsullivan commented Mar 11, 2019

Copy link
Copy Markdown
Member

jenkins test this

@elasticmachine

elasticmachine commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

tsullivan
tsullivan approved these changes Mar 11, 2019
View reviewed changes

@tsullivan tsullivan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsullivan
tsullivan merged commit d301433 into elastic:master Mar 11, 2019
@tsullivan tsullivan mentioned this pull request Mar 11, 2019
Merged
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Mar 11, 2019
@varunsharma27 @tsullivan
Removes Unused react-toggle dependency. (elastic#29086)
e269e5a 
* Removes Unused react-toggle dependency.

* PR elastic#29086 Updates yarn.lock
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Mar 11, 2019
@varunsharma27 @tsullivan
Removes Unused react-toggle dependency. (elastic#29086)
b60af53 
* Removes Unused react-toggle dependency.

* PR elastic#29086 Updates yarn.lock
@tsullivan tsullivan mentioned this pull request Mar 11, 2019
Closed
tsullivan added a commit that referenced this pull request Mar 13, 2019
@tsullivan
[7.x] Removes Unused react-toggle dependency. (#29086) (#32944)
d21b567 
* Removes Unused react-toggle dependency. (#29086)

* Removes Unused react-toggle dependency.

* PR #29086 Updates yarn.lock

* yarn changes
@rayafratkina rayafratkina added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Mar 22, 2019
@elasticmachine

elasticmachine commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@varunsharma27 @tsullivan
Removes Unused react-toggle dependency. (elastic#29086)
d14ca3c 
* Removes Unused react-toggle dependency.

* PR elastic#29086 Updates yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees

No one assigned

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.0.0 v7.2.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@varunsharma27 @elasticmachine @tsullivan @rayafratkina