Repository navigation
management/kibana/indices => management/kibana/index_patterns - #29151
Merged
Merged
Conversation
management/kibana/indices => management/kibana/index_patterns
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
chrisdavies
approved these changes
Jan 24, 2019
chrisdavies
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I didn't pull down and test, but this looks like a reasonable changeset. I'm glad to see some work going into consistency issues!
|
I think this is a breaking change because the URLs are changing... though I doubt anyone booked marked the indices pattern page. :) . But just to be safe, and since we are close anyway, I don't think this should be backported to 6.7. Otherwise, lgtm too (likewise didn't pull down and test), but great to see some clean up! 🎉 |
This was referenced Jan 29, 2019
Contributor
|
@mattkime Could you please add this change to the Breaking Changes doc? |
Contributor
|
Pinging @elastic/kibana-app |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…astic#29151) * partial progress * fix routing, account for create flow * fix test * fix test * fix test * fix next page after delete * fix test * indices refs to index_patterns as appropriate * more refactor and potential test fix * change more urls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing management ui uses
indicesandindexfor index pattern urls and code irregularly which is misleading.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately