Repository navigation
Inter UI and roboto mono font stack. Remove K6 theming. We did it - #29152
Conversation
|
cc @spalger. This PR might cause a very small conflict in your theming PR. Note that for K7 we should not be loading the K6 theme files any longer (which is what this PR does) |
💔 Build Failed |
|
Tests are related to the snake case file names and needing to update the PNGs for the functional tests. Will fix both in the morning. |
There was a problem hiding this comment.
So the biggest changes that we will see will be due to the fact that the base font size has changed from 14px to 16px. Most of the time this should be fine, especially where EUI is being used. However, you can see some pretty drastic size changes in screens like these:
There are some instances where the smaller font size is probably preferred, like in the title bars of dashboard panels. So we might want to comb through a bit to see where we might want to reduce the font size.
💔 Build Failed |
💔 Build Failed |
|
I spent a few hours doing cleanup of font issues. There are likely to be more, but i think the very obvious ones were attacked. Couple notes for discussion tomorrow:
|
|
I added some notes to the top for teams who are getting pinged due to snapshot / minor font changes. |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
@spalger I merged up now that nav is in. Unfortunately this PR still breaks in the same places :( |
💔 Build Failed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
💚 Build Succeeded |
|
@snide Could you please add this change to the 7.0 Breaking Changes doc? |
…astic#29152) Adds inter ui as the default font for Kibana. Removes the K6 theming. Kibana now uses EUI default.
Summary
This PR does the following things:
For outside team pings
Notes
I included the full stack of files that Google fonts and Inter UI provided. In many cases these files will not be used (either because a variable file is loaded, or we're not calling the font-face directly), but generally having lived in the Kibana font code for 2 years I've found it prudent to include the full set since these are versioned and you never know when you'll need them. It gives us some room should we need it later.
Testing
I tested this on Chrome, Firefox, Safari and IE11. Firefox has the best tooling for fonts if you're looking to get designy with them. I did not do a full visual check of this stuff. I think @cchaos, who is more familiar with these fonts will do a better job there. But they are rendering at the weights I expect.
Stuff to check
Because the fonts are different, anything that may have used a fixed width or height based on "eyeball" values has the potential to break. For example, if you sized a column because "that looks about 300px of content" rather than making a calculation based on variables, that column may no be 300px.
K6's base font size was 14px. K7s is 1rem/16px. In some cases you might see subtext content (like subtitles) looking large. The fix is always to just use
EuiTextand apply a smaller size if that's what you think looks better. I tried to get as many instances of those in this PR as I could.Breaking change
This is a breaking change to dashboards for 7.0. It will cause pixel level height differences vs K6 because of differences in font size and weight. We'll need to update the baseline screenshots to match.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers