Repository navigation
Fix/reporting vis preserve - #30456
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
tsullivan
commented
Feb 8, 2019
| }; | ||
| } | ||
| return { | ||
| id: this.props.reportType === 'png' ? 'png' : 'preserve_layout', |
Member
Author
There was a problem hiding this comment.
NOTE: the previous code would have an undefined id field when the export type was PNG. This changes it to have an id: 'png' value. There doesn't seem to be any functional change from this
Contributor
There was a problem hiding this comment.
Interesting, good catch. At least it's less ambiguous now.
Contributor
💚 Build Succeeded |
joelgriffith
approved these changes
Feb 8, 2019
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 8, 2019
* add state field for isPreserveLayoutSupported * doc updates
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 8, 2019
* add state field for isPreserveLayoutSupported * doc updates
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 8, 2019
* add state field for isPreserveLayoutSupported * doc updates
tsullivan
added a commit
that referenced
this pull request
Feb 11, 2019
tsullivan
added a commit
that referenced
this pull request
Feb 13, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* add state field for isPreserveLayoutSupported * doc updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #30001
Release Note: In the Visualization Editor, the "Optimize for printing" option has been removed when exporting the visualization as PNG or PDF. The single visualization will automatically be optimized for printing.