Skip to content

[ML] General ML style tweaks for K7 compatibility - #30536

Merged
jgowdyelastic merged 2 commits into
elastic:masterfrom
jgowdyelastic:k7-style-tweaks
Feb 12, 2019
Merged

jgowdyelastic merged 2 commits into
elastic:masterfrom
jgowdyelastic:k7-style-tweaks

Conversation

@jgowdyelastic

@jgowdyelastic jgowdyelastic commented Feb 8, 2019 •

Copy link
Copy Markdown
Member

Adds some padding to the top of the navigation bar on all of the data visualizer and settings pages as they don't use the time picker.
These pages also had some oddities where a scrollbar would constantly be present and the background colour was being overridden.

Before:
image

After:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@jgowdyelastic
jgowdyelastic requested review from a team as code owners February 8, 2019 16:12
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title [ML] [WIP] General ML style tweaks for K7 compatibility [ML] General ML style tweaks for K7 compatibility Feb 8, 2019

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also tested on IE11.

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jgowdyelastic
jgowdyelastic merged commit 7c48cd3 into elastic:master Feb 12, 2019
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
jgowdyelastic added a commit that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
jgowdyelastic added a commit that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants