Repository navigation
[Uptime] Remove double-format for duration value - #30664
Merged
justinkambic merged 1 commit intoFeb 11, 2019
Merged
justinkambic merged 1 commit into
justinkambic merged 1 commit into
Conversation
Contributor
|
Pinging @elastic/uptime |
Contributor
💚 Build Succeeded |
Contributor
Author
|
This defect doesn't exist in the |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Feb 11, 2019
justinkambic
added a commit
that referenced
this pull request
Feb 12, 2019
Contributor
Author
|
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Feb 14, 2019
justinkambic
added a commit
that referenced
this pull request
Feb 14, 2019
Contributor
💚 Build Succeeded |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #30559.
We're presently double-formatting the status bar's duration value from microseconds to milliseconds. This is effectively causing us to display the μs value as fraction number seconds, instead of millis. Given that we append the text
msbehind it, this is completely incorrect and confusing (how are my requests completing in0.3ms???).These changes will fix that bug.
A later change is going to remove any value formatting from the client altogether.Before
After
Testing this PR