Skip to content

Exclude migrationVersion and references from getRootPropertiesObjects result - #30081

Merged
mikecote merged 2 commits into
elastic:masterfrom
mikecote:mappings/get-root-properties-objects-blacklist
Feb 5, 2019
Merged

mikecote merged 2 commits into
elastic:masterfrom
mikecote:mappings/get-root-properties-objects-blacklist

Conversation

@mikecote

@mikecote mikecote commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

Fixes #29869

This PR modifies getRootPropertiesObjects function of mappings to exclude migrationVersion and references as they are not object types. The approach is to create a blacklist of properties to exclude.

@mikecote mikecote added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.0.0 labels Feb 5, 2019
@mikecote mikecote self-assigned this Feb 5, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-platform

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@mikecote

mikecote commented Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

retest

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@mikecote
mikecote requested a review from legrego February 5, 2019 16:43
@mikecote mikecote added the review label Feb 5, 2019

@legrego legrego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mikecote!

@mikecote
mikecote merged commit f852812 into elastic:master Feb 5, 2019
@kobelb

kobelb commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

Thanks @mikecote!!!

@mikecote mikecote added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 22, 2019
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants