Repository navigation
[Uptime] Re-add missing loading states for filter bar and snapshot components. - #30122
Merged
justinkambic merged 1 commit intoFeb 5, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/uptime |
Contributor
💚 Build Succeeded |
andrewvc
approved these changes
Feb 5, 2019
andrewvc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Looked great in my browser.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Feb 5, 2019
justinkambic
added a commit
that referenced
this pull request
Feb 5, 2019
Contributor
Author
Contributor
💚 Build Succeeded |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Somehow the loading states we added in #29858 were removed. This PR re-introduces them, and improves the layout mirroring of the snapshot's loading state.