Repository navigation
Add autocomplete to TSVB - #30158
Merged
Merged
Add autocomplete to TSVB#30158
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Closed
Contributor
Author
|
Retest |
Contributor
💚 Build Succeeded |
lukasolson
added a commit
that referenced
this pull request
Feb 7, 2019
* Add autocomplete to TSVB * Remove unused imports * Remove unnecessary ts-ignore
lukasolson
added a commit
that referenced
this pull request
Feb 7, 2019
* Add autocomplete to TSVB * Remove unused imports * Remove unnecessary ts-ignore
Contributor
Author
| import { getFromSavedObject } from 'ui/index_patterns/static_utils'; | ||
| import { VisSavedObject } from 'ui/visualize/loader/types'; | ||
|
|
||
| export async function getIndexPattern( |
There was a problem hiding this comment.
What was the reasoning behind putting this function in the embeddable folder? It doesn't seem to be tied to embeddables, and relies on specific visualization saved object knowledge.
Contributor
Author
There was a problem hiding this comment.
You're right, this should be moved to public/visualize somewhere
There was a problem hiding this comment.
Do you mind pulling together a follow up PR for this move?
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Add autocomplete to TSVB * Remove unused imports * Remove unnecessary ts-ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds autocomplete to TSVB on dashboards.
This is the first phase as it only autocompletes on the index pattern you've selected for your panel data, not custom series index patterns or annotations. (This will require rewiring some things to allow multiple index patterns.)