Repository navigation
[ML] Fixing metric select double caret - #30357
Merged
jgowdyelastic merged 1 commit intoFeb 7, 2019
Merged
jgowdyelastic merged 1 commit into
jgowdyelastic merged 1 commit into
Conversation
jgowdyelastic
requested review from
alvarezmelissa87,
peteharverson and
walterra
February 7, 2019 09:20
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
peteharverson
approved these changes
Feb 7, 2019
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Works on IE11 too.
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 7, 2019
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 7, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Feb 8, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Feb 8, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing which was adding an additional caret to the metric selects in the multi-metric and population wizards.
Rule originally added in this PR: #19816
Which is now redundant due to this PR: #29658
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.