Repository navigation
Add flex wrap to metric vis container - #31891
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
Author
|
failure seems unrelated: Jenkins, test this |
Contributor
💚 Build Succeeded |
Contributor
|
I would highly suggest making sure to test this in IE before merging since it's notoriously bad with flex. |
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Mar 1, 2019
lukeelmers
left a comment
Contributor
There was a problem hiding this comment.
LGTM, (assuming IE11 works once master is fixed). Tested Chrome OSX.
Contributor
|
wow nice, code LGTM |
cchaos
approved these changes
Mar 6, 2019
cchaos
left a comment
Contributor
There was a problem hiding this comment.
Checked on Chrome and IE11 and it works great, even if it still needs to scroll. Thx
Contributor
|
We should get this merged in soon. |
Contributor
💚 Build Succeeded |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Mar 15, 2019
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Mar 15, 2019
markov00
added a commit
that referenced
this pull request
Mar 15, 2019
markov00
added a commit
that referenced
this pull request
Mar 15, 2019
Contributor
Author
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Apr 8, 2019
markov00
added a commit
that referenced
this pull request
Apr 9, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #26400
As suggested, this PR add a
flex-wrap: wrapto wrap metric values on new line if they exceed the available width.This keep the vertically centered behaviour of single metrics, it wrap multiple metrics on new rows.
However, depending on the value or on the label length, each cell has a different width and will not render as a nice grid (as shown in the second screenshot). Adding a min-width equal to the max-content could be done in a different PR if required (unfortunately this will involves computing the max content size on the first render, and adjust on the second render the size, causing a small flick. A second solution can use external rendering of text , on canvas for example, to compute the width. I'm not aware of any better solution for that case.).
Note for QA
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[x] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately