Skip to content

[ML] Adding calendars list to job management - #32566

Merged
jgowdyelastic merged 1 commit into
elastic:masterfrom
jgowdyelastic:addling-calendars-list-to-job-management
Mar 7, 2019
Merged

[ML] Adding calendars list to job management#32566
jgowdyelastic merged 1 commit into
elastic:masterfrom
jgowdyelastic:addling-calendars-list-to-job-management

Conversation

@jgowdyelastic

@jgowdyelastic jgowdyelastic commented Mar 6, 2019

Copy link
Copy Markdown
Member

Adds a list of the Job's calendars to the Job settings tab when expanding a row in the Job Management page.

This is a regression in behaviour from the old angular Job Management page.

image

@jgowdyelastic jgowdyelastic self-assigned this Mar 6, 2019
@jgowdyelastic
jgowdyelastic requested a review from a team as a code owner March 6, 2019 16:24
@elasticmachine

elasticmachine commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui

peteharverson
peteharverson approved these changes Mar 6, 2019
View reviewed changes

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 6, 2019
View reviewed changes

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine

elasticmachine commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic added the bug Fixes for quality problems that affect the customer experience label Mar 7, 2019
walterra
walterra approved these changes Mar 7, 2019
View reviewed changes

@walterra walterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic
jgowdyelastic merged commit 37c47f6 into elastic:master Mar 7, 2019
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 7, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 7, 2019
@jgowdyelastic
[ML] Adding calendars list to job management (elastic#32566)
2a7c881
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 7, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 7, 2019
@jgowdyelastic
[ML] Adding calendars list to job management (elastic#32566)
9402bee
jgowdyelastic added a commit that referenced this pull request Mar 7, 2019
@jgowdyelastic
[ML] Adding calendars list to job management (#32566) (#32631)
f0dc891
jgowdyelastic added a commit that referenced this pull request Mar 7, 2019
@jgowdyelastic
[ML] Adding calendars list to job management (#32566) (#32630)
df4512c
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 7, 2019
Merged
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@jgowdyelastic
[ML] Adding calendars list to job management (elastic#32566)
b683062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes
@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes
@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels

bug Fixes for quality problems that affect the customer experience :ml regression review v7.0.0 v7.2.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson