Repository navigation
Export workpad: Copy to clipboard should read "To generate a PDF from a script or with Watcher, use this URL." - #32880
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
bhavyarm
reviewed
Mar 11, 2019
bhavyarm
left a comment
Contributor
There was a problem hiding this comment.
@rockfield Neat fix but I had a suggestion. Can we change the label to ** Alternatively, you can generate a PDF from a script or with Watcher by using this URL. Hit enter to copy the URL to clipboard**.
Contributor
Author
|
Yes, thanks. I’m updating this.
|
Contributor
Author
|
@bhavyarm, updated. Please have a look. |
Contributor
💚 Build Succeeded |
Contributor
|
@rockfield this is a tiny nit. Can we remove the period at the end of the label? I think it's influencing the tone of the screenreader. Apologies for not mentioning it earlier. I realized it now when I was looking at the screenshot. Thanks! |
w33ble
approved these changes
Mar 11, 2019
alexwizp
approved these changes
Mar 12, 2019
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
1 similar comment
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
PhilippBaranovskiy
added a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 13, 2019
… a script..." (elastic#32880) * Copy POST URL for generating PDF outside of Kibana ScreenReader compability
PhilippBaranovskiy
added a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 13, 2019
… a script..." (elastic#32880) * Copy POST URL for generating PDF outside of Kibana ScreenReader compability
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
… a script..." (elastic#32880) * Copy POST URL for generating PDF outside of Kibana ScreenReader compability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #25502
Summary
I've added a proper aria-label attribute.
I wrote that without translation since this is Canvas plugin with a separated translating process.