Skip to content

[ML] Changing job wizard query to use match_all - #32008

Merged
jgowdyelastic merged 3 commits into
elastic:masterfrom
jgowdyelastic:changing-job-wizard-query-to-use-match_all
Feb 26, 2019
Merged

jgowdyelastic merged 3 commits into
elastic:masterfrom
jgowdyelastic:changing-job-wizard-query-to-use-match_all

Conversation

@jgowdyelastic

@jgowdyelastic jgowdyelastic commented Feb 26, 2019 •

Copy link
Copy Markdown
Member

Changes the query used to draw the line charts in the wizards and used in the datafeed to be:

match_all: {}

rather than

query_string: {	   
  analyze_wildcard: true,	
  query: '*'	
}

Also removes the filters object returned from createSearchItems() but which are no longer used.
query and filters are combined to create combinedQuery which is used for every search.
query is only used in the data visualizer page as it requires a lucene query string.

Fixes #31924

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review backport pending :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.2.0 v7.0.1 labels Feb 26, 2019
@jgowdyelastic jgowdyelastic self-assigned this Feb 26, 2019
@jgowdyelastic
jgowdyelastic requested a review from a team as a code owner February 26, 2019 12:18
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title [ML] Using job wizard query to use match_all [ML] Changing job wizard query to use match_all Feb 26, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jgowdyelastic
jgowdyelastic merged commit f89faec into elastic:master Feb 26, 2019
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 26, 2019
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
jgowdyelastic added a commit that referenced this pull request Feb 26, 2019
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 28, 2019
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 28, 2019
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
jgowdyelastic added a commit that referenced this pull request Feb 28, 2019
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml review v6.7.1 v7.0.0 v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Change wizard's search query to use match_all

5 participants