Skip to content

[dev/run] options can modify help, errors can show help - #33466

Merged
spalger merged 5 commits into
elastic:masterfrom
spalger:implement/dev-run-help-opts
Mar 19, 2019
Merged

spalger merged 5 commits into
elastic:masterfrom
spalger:implement/dev-run-help-opts

Conversation

@spalger

@spalger spalger commented Mar 19, 2019 •

Copy link
Copy Markdown
Contributor

In order to make the dev/run helpers a little more helpful, I've added a couple options to the run() function and documented it (along with its new options) in https://github.com/elastic/kibana/blob/bf732ca104bec2a9f4ddc504c049f297849b9fc5/src/dev/run/README.md.

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@spalger
spalger merged commit ba4597e into elastic:master Mar 19, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Mar 19, 2019
* [dev/run] options can modify help, errors can show help

* include minor tooling log usage

* cleanup wording a little

* cleanup run options

# Conflicts:
#	src/dev/test_stats/get_test_stats_cli.ts

* explicitly document opts that are passed to getopts
spalger pushed a commit to spalger/kibana that referenced this pull request Mar 19, 2019
* [dev/run] options can modify help, errors can show help

* include minor tooling log usage

* cleanup wording a little

* cleanup run options

# Conflicts:
#	src/dev/test_stats/get_test_stats_cli.ts

* explicitly document opts that are passed to getopts
spalger pushed a commit that referenced this pull request Mar 19, 2019
)

* [dev/run] options can modify help, errors can show help

* include minor tooling log usage

* cleanup wording a little

* cleanup run options

# Conflicts:
#	src/dev/test_stats/get_test_stats_cli.ts

* explicitly document opts that are passed to getopts
spalger pushed a commit that referenced this pull request Mar 19, 2019
)

* [dev/run] options can modify help, errors can show help

* include minor tooling log usage

* cleanup wording a little

* cleanup run options

# Conflicts:
#	src/dev/test_stats/get_test_stats_cli.ts

* explicitly document opts that are passed to getopts
@spalger

spalger commented Mar 19, 2019

Copy link
Copy Markdown
Contributor Author

7.x/7.1: e686cfd
7.0: 52d6aa6

@spalger
spalger deleted the implement/dev-run-help-opts branch March 19, 2019 17:39
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [dev/run] options can modify help, errors can show help

* include minor tooling log usage

* cleanup wording a little

* cleanup run options

# Conflicts:
#	src/dev/test_stats/get_test_stats_cli.ts

* explicitly document opts that are passed to getopts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants