Repository navigation
[dev/run/logLevels] flags are bools, don't capture values - #33528
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations |
jbudz
approved these changes
Mar 19, 2019
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 19, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 19, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 21, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 22, 2019
Contributor
Author
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling a script that uses the
dev/runhelpers with the default log level flags, like--debug, sets the log level of the internal tooling log. These flags all default tofalseso that getopts doesn't think they are unexpected, but that doesn't tell getopts to treat them as boolean flags which causes problems when using "naked" arguments like so:# sets debug flag to foo node scripts/my_script --debug foo# sets debug flag to true and include `foo` in `_` flags node scripts/my_script foo --debugThis ordering restriction makes for fragile scripts and can be fixed by telling getopts to treat the logging flags as booleans (which defaults them to false anyway).