Repository navigation
Fix custom icon image paths in NavDrawer - #33573
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform |
epixa
approved these changes
Mar 20, 2019
epixa
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I didn't test this out locally, but the code looks good.
Contributor
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Mar 20, 2019
This was referenced Mar 20, 2019
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Mar 20, 2019
Contributor
@joshdover Do you think since this does affect some users/plugin authors that this should be included in the release notes? |
joshdover
added a commit
that referenced
this pull request
Mar 20, 2019
joshdover
added a commit
that referenced
this pull request
Mar 20, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33430
Custom icon images were broken in the NavDrawer because we weren't adding the basePath to the image URL.
To test, follow the reproduction steps in the issue above. Note that the icon is white so you can't really see it now, but that should be fine since this feature is for 3rd party plugins now, not us. They'll need to supply new, darker icons to show up in the nav drawer.