Repository navigation
[ML] Skip invalid modules when data recognizer lists matches - #33703
Merged
peteharverson merged 2 commits intoMar 22, 2019
Merged
Conversation
peteharverson
requested review from
alvarezmelissa87,
jgowdyelastic and
walterra
March 22, 2019 13:29
Contributor
|
Pinging @elastic/ml-ui |
| id: `${prefix}${job.id}`, | ||
| config: JSON.parse(jobConfig) | ||
| }); | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
Would it be useful to log out the actual error being caught somewhere?
Contributor
Author
There was a problem hiding this comment.
Yes, good point. I'll append the error to these log messages.
alvarezmelissa87
approved these changes
Mar 22, 2019
alvarezmelissa87
left a comment
Contributor
There was a problem hiding this comment.
LGTM ⚡️
Just left a small comment.
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 22, 2019
…#33703) * [ML] Skip invalid modules when data recognizer lists matches * [ML] Append error to data recognizer module load console logs
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 22, 2019
…#33703) * [ML] Skip invalid modules when data recognizer lists matches * [ML] Append error to data recognizer module load console logs
peteharverson
added a commit
that referenced
this pull request
Mar 22, 2019
peteharverson
added a commit
that referenced
this pull request
Mar 22, 2019
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
* [ML] Skip invalid modules when data recognizer lists matches * [ML] Append error to data recognizer module load console logs
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…#33703) * [ML] Skip invalid modules when data recognizer lists matches * [ML] Append error to data recognizer module load console logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If the data recognizer encounters an error when checking each of the available modules under
x-pack/plugins/ml/server/models/data_recognizer/modules, the folder is now ignored and processing moves to the next folder. Before the check would fail, with an HTTP 500 server error, and no matching modules would be displayed in the job wizard or data visualizer.A warning message is now logged in the Kibana server console if an error is encountered, for example if:
manifest.jsonfile in the module foldermanifest.jsonis not valid JSONmanifest.jsonfile failsIn the second step of the wizard, after selecting the module to load, if an error occurs in any of the steps (loading jobs, loading datafeeds, loading saved objects), an error is logged on the server, and that specific configuration is ignored. Note a future enhancement would be to propagate details of the step that failed through to the client.
Also added error handling to the step which sets up the module in the Create Job wizard, so that a toast notification is displayed if an error occurs saving the jobs and saved objects defined in the file.
Checklist
For maintainers
Fixes #33665