Repository navigation
[ML] Adds created_by field to auditbeat and APM data recognizer jobs - #33863
Merged
peteharverson merged 1 commit intoMar 27, 2019
Merged
Conversation
peteharverson
requested review from
alvarezmelissa87,
jgowdyelastic and
walterra
March 26, 2019 17:13
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
droberts195
reviewed
Mar 27, 2019
| }, | ||
| "custom_settings": { | ||
| "created_by": "ml-module-auditd-hosts", | ||
| "created_by": "ml-module-auditbeat-process-hosts", |
There was a problem hiding this comment.
Changing this makes life hard for the telemetry repo because jobs will exist in the wild that have a value of ml-module-auditd-hosts, so then the telemetry repo will have to cope with both.
There was a problem hiding this comment.
Actually, it looks like ml-module-auditd-hosts wasn't in 6.7 - is that correct? If so, I'd be happy to change this provided this PR gets backported to 7.0 in time for 7.0.0-rc2. The problem only arises if people will have jobs existing in clusters that get upgraded to 7.1 containing ml-module-auditd-hosts.
Contributor
Author
There was a problem hiding this comment.
I will go with ml-module-auditbeat-process-hosts and ml-module-auditbeat-process-docker and backport to 7.0.
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 27, 2019
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 27, 2019
peteharverson
added a commit
that referenced
this pull request
Mar 27, 2019
peteharverson
added a commit
that referenced
this pull request
Mar 27, 2019
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
created_byproperty to thecustom_settingsfield for the job configurations in the APM Transaction and Auditbeat Docker Processes data recognizer modules, which had been left off in the original configurations. This setting is used to identify the job wizard that was used to create the job.Also edited the value of the
created_byfield for the Auditbeat Host Processes to make it consistent with the value of the module ID.Checklist
For maintainers