Repository navigation
[TSVB] add controls to toggle disable/enable individual series and annotations - #33107
Merged
Merged
Conversation
Contributor
💚 Build Succeeded |
markov00
reviewed
Mar 15, 2019
markov00
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM. Tested locally and works fine.
The main concern is on the markdown implementation: on all the other we just hide the series without any error. On Markdown, if we hide a series that was previously added in the markdown it will throw an error. What if we just temporary hide every variables that are related to hidden series?
I've also rised a concern on EUI tooltip that behave in a strange when only one series is present and the hide/show button is clicked rapidly elastic/eui#1734.
Contributor
Author
|
@markov00 Thanks, I've checked this one for Markdown. I think we can disable this functionality for this panel. I'll update my PR |
Contributor
💚 Build Succeeded |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Mar 18, 2019
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Mar 18, 2019
…notations (elastic#33107) # Conflicts: # src/legacy/core_plugins/metrics/server/lib/vis_data/get_series_data.js # src/legacy/core_plugins/metrics/server/lib/vis_data/table/process_bucket.js
alexwizp
added a commit
that referenced
this pull request
Mar 18, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #23210
Summary
[TSVB] add controls to toggle disable/enable individual series and annotations
Screens:
Series:
Annotations:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers